On Mon, 25 Oct 2021 19:50:54 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Based on my local testing it appears the localization system falls back to 
>> the English values when entries are missing, so it appears the current 
>> behavior does already match what you've suggested.  However, I don't 
>> understand the mechanism that implements this fallback handling, so I'm not 
>> sure the behavior would be consistent across environments.  At least for now 
>> I'll add those entries back with the English translations copied, since that 
>> seems better.
>
>> Based on my local testing it appears the localization system falls back to 
>> the English values when entries are missing, so it appears the current 
>> behavior does already match what you've suggested. However, I don't 
>> understand the mechanism that implements this fallback handling, so I'm not 
>> sure the behavior would be consistent across environments. At least for now 
>> I'll add those entries back with the English translations copied, since that 
>> seems better.
> 
> Ok. That change looks good, but you need to update the copyright in those two 
> files.

> @plummercj Looks like this is all ready to go then. Would you be willing to 
> sponsor it for integration?

Yes. I'm doing some testing with our CI now. I'll integrate once that is done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5290

Reply via email to