On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate > - fixes up resulting errors since this changes uncovers missing dependencies. > Mainly, missing includes of debug.hpp, of globalDefinitions.hpp, and missing > outputStream definitions. > > Changes are trivial but onerous. Done partly with a script, partly manually. > > Test: > - Checked the build with gtests on Linux x86, x64, minimal, zero, aarch64, > for both fastdebug and release. All builds of course without PCH. > - GHAs BTW, I have some scripts for checking how often a header file is included. See https://github.com/iklam/tools/tree/main/headers count_hotspot_headers.tcl shows that allocation.hpp was included by 1006 .o files before this fix, and 996 files afterwards, so not a whole lot of reduction. That's because we have over 300 headers that include allocatons.hpp :-) ------------- PR: https://git.openjdk.java.net/jdk/pull/7188
