On Mon, 24 Jan 2022 02:43:04 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Hi Thomas, > > Seems okay - hard to validate (and I expect allocation.hpp to be included > somewhere in most cases anyway). > It shouldn't, that's the idea of JDK-8249944. > Some of the changes seem to have nothing to do with: > > -#include "memory/allocation.hpp" +#include "memory/allStatic.hpp" > > ? Are these caused by transitive include changes? > See my comment in code. All places that needed to be fixed. > Thanks, David Thanks for the review, ..Thomas > src/hotspot/share/cds/archiveUtils.cpp line 44: > >> 42: #include "utilities/debug.hpp" >> 43: #include "utilities/formatBuffer.hpp" >> 44: #include "utilities/globalDefinitions.hpp" > > Seems unrelated to this issue. archiveUtils.cpp misses debug.hpp (since it uses assert) and globalDefinitions.hpp (since it uses types from there) but missed these includes. This had been hidden by one of its includes pulling allocation.hpp. Same goes for the other seemingly unrelated fixups: all missing includes hidden by including allocation.hpp ------------- PR: https://git.openjdk.java.net/jdk/pull/7188
