On Sat, 19 Feb 2022 04:00:30 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> This test has 4 test cases/modes: two core files test cases and two process. > Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to > run when `-XX:+DeoptimizeALot` is used, because the test does some checks > that assume certain methods will be compiled. This is handled by adding the > following to the test case: > > ` * @requires vm.opt.DeoptimizeALot != true` > > When this was first added, only the process test cases existed. Later on the > core tests cases were added, and the `@requires` was copied improperly. It > ended up with `#no-xcomp-process` rather than `#xcomp-core`, which allows the > `#xcomp-core` test case to run even when `-XX:+DeoptimizeALot` is being used. Sorry Chris but things still seem a bit confused to me. David test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java line 49: > 47: * @bug 8193124 > 48: * @summary Test the clhsdb 'findpc' command with Xcomp on core file > 49: * @requires vm.compMode != "Xcomp" The summary says "with Xcomp" but the requires says "!= Xcomp" ??? test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java line 61: > 59: * @bug 8193124 > 60: * @summary Test the clhsdb 'findpc' command w/o Xcomp on live process > 61: * @requires vm.hasSA Summary says w/o xcomp but no requires clause to reject Xcomp mode ------------- PR: https://git.openjdk.java.net/jdk/pull/7542
