On Thu, 19 May 2022 15:29:14 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c line 880:
>> 
>>> 878:  "onuncaught=y|n                   debug on any uncaught?            
>>> n\n"
>>> 879:  "timeout=<timeout value>          for listen/attach in milliseconds 
>>> n\n"
>>> 880:  "enumeratevthreads=y|n            (Preview Feature) thread lists 
>>> include all vthreads\n"
>> 
>> I think the description needs to say "virtual threads" rather than 
>> "vthreads". Also I think "(Preview" needs to go after "virtual threads" to 
>> make it clearer that it's virtual threads that are preview,.
>
> I was really trying to emphasize that the flag is preview, and therefore may 
> change or go away.  If I change as  you suggest, the reader could imply that 
> as long as virtual threads support is in place, then the flag will be also 
> (and in its current form).

I agree with @plummercj , this is documenting that the flag is itself a 
"preview feature" and thus subject to change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8780

Reply via email to