On Fri, 1 Jul 2022 18:17:35 GMT, Chris Plummer <[email protected]> wrote:
>> This fixes a bug in the debug agent when there is a request to suspend a
>> virtual thread that has already terminated. The issue was that unless the
>> debug agent was currently under a "suspend all", it would not properly put
>> the virtual thread on the `otherThreads` list, and instead added it to
>> `runningVThreads`. This meant at the end of `insertThread()` the following
>> code tried to do a JVMTI `SetThreadLocalStorage`, which can't be done on a
>> terminated thread.
>>
>>
>> if (list != &otherThreads) {
>> setThreadLocalStorage(node->thread, (void*)node);
>> }
>
> Chris Plummer has updated the pull request incrementally with one additional
> commit since the last revision:
>
> provide a slightly more descriptive @summary
test/jdk/com/sun/jdi/TestScaffold.java line 976:
> 974: }
> 975: });
> 976: Thread.currentThread().setName(OLD_MAIN_THREAD_NAME);
Just want to understand what is this thread naming is about.
Is it just to properly name the threads, or there is some other reason for this?
Also, why OLD_MAIN_THREAD_NAME is a little bit strange and why old?
-------------
PR: https://git.openjdk.org/jdk19/pull/88
