It sure looks like a bug. I guess no one has ever used this C++ interface, or even included this header file from a C++ compilation. The debug agent itself is written in C and calls the C version of this API, which is located earlier in the file. So this header file does compile from C, but the syntax error you've pointed out is within a #ifdef __cplusplus, so is not compiled by the debug agent.

The following link will help you get started with making a contribution:

https://wiki.openjdk.org/display/Adoption/New+Contributor

Thanks,

Chris

On 10/18/22 8:48 AM, 小破 wrote:
Firstly, this is my first-time sending an email to OpenJDK Community. If I chose a wrong list name in this mailing list <https://mail.openjdk.org/mailman/listinfo>, please forgive me and tell me which email address I should send to.

When I read the JDK source code, I found some codes a little special in the jdwpTransport.h. From line 265 to line 267 (the code link: jdwpTransport.h#L265-L267 <https://github.com/openjdk/jdk/blob/master/src/jdk.jdwp.agent/share/native/include/jdwpTransport.h#L265-L267>):
```
jdwpTransportError SetTransportConfiguration(jdwpTransportEnv* env,
returnfunctions->SetTransportConfiguration(this, config);
}
```
It seems that there is a syntax error. When I try to compile this file, compilation errors do occur. So, I want to know whether it is a bug or not. If it is, I want to fix it. And then it will be my first time trying to contribute to OpenJDK, I need someone to tell me the process of contributing code to OpenJDK.

Thanks and regards.

------------------------------------------------------------------------
        
阿破
[email protected]

<https://wx.mail.qq.com/home/index?t=readmail_businesscard_midpage&nocheck=true&name=%E9%98%BF%E7%A0%B4&icon=http%3A%2F%2Fthirdqq.qlogo.cn%2Fg%3Fb%3Dsdk%26k%3DuRa3wVPibCtiaxMGbfjYCibaw%26s%3D100%26t%3D1556479581%3Frand%3D1636189913&mail=1052156701%40qq.com&code=>

Reply via email to