On Thu, 27 Oct 2022 15:01:18 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> All dispose tests fixed.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java
> line 140:
>
>> 138: if (Utils.isAlive(test_thread)) {
>> 139: pipe.println("alive");
>> 140: logErr("ERROR thread is alive
>> after vm.dispose()");
>
> You've added a nice diagnostic line here for this case of the thread
> being unexpectedly alive, but you didn't do so for the other test cases
> that you've updated in v01. Is this log mesg not applicable in those cases?
Added to all tests.
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004a.java
> line 140:
>
>> 138: log1("checking on: thread2.isAlive");
>> 139: if (Utils.isAlive(test_thread)) {
>> 140: pipe.println("alive");
>
> Add new log mesg here?
done
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose005a.java
> line 156:
>
>> 154: } else {
>> 155: log1("checking on:
>> testedThread.isAlive");
>> 156: if (!test_thread.done) {
>
> The log mesg says "checking on: testedThread.isAlive", but that's not
> quite true. It's checking the `test_thread.done` flag which is not the
> same thing. Maybe I'm splitting too fine a hair here...
fixed
-------------
PR: https://git.openjdk.org/jdk/pull/10877
