On Tue, 13 Dec 2022 22:00:04 GMT, Coleen Phillimore <[email protected]> wrote:
>> These access flags were implemented to enable passing access flag values
>> from Method* to InstanceKlass*, but only covered one flag. Towards only
>> have access flags represent read-only flags in the class file, remove this
>> and pass has_localvariable_table up to InstanceKlass in classfile parsing,
>> like we do with other flags.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add a space
Changes looks good. One query below.
Thanks.
src/hotspot/share/oops/instanceKlassMiscStatus.cpp line 64:
> 62: #ifdef ASSERT
> 63: void InstanceKlassMiscStatus::assert_is_safe(bool set) {
> 64: // Setting a flag is safe if it's set once or at a safepoint.
> RedefineClasses can set or
Is this a generally true statement, or only true for specific flags?
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11655
