On Thu, 5 Jan 2023 02:37:45 GMT, David Holmes <[email protected]> wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add doc; readImpl/closeImpl to read/close
>
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line
> 372:
>
>> 370: }
>> 371:
>> 372: void processCompletionStatus(IOException ioe, String cmd,
>> InputStream sis) throws AgentLoadException, IOException {
>
> Some doc comments for this method would be good.
I was thinking more about describing what the parameters are - in particular it
is unclear why the actual IOE can be replaced by a passed in one. If we wanted
a custom message then I would at least expect to chain the actual IOE to the
replacement.
-------------
PR: https://git.openjdk.org/jdk/pull/11823
