On Wed, 11 Jan 2023 20:53:38 GMT, Justin King <jck...@openjdk.org> wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of >> `MmapArrayAllocator` have been switched to normal `malloc`. The >> justification is that none of the code paths are called from signal >> handlers, so using `mmap` directly does not make sense and is potentially >> slower than going through `malloc` which can potentially re-use memory >> without making any system calls. The remaining usages of `ArrayAllocator` >> and `MallocArrayAllocator` are equivalent. > > Justin King has updated the pull request incrementally with one additional > commit since the last revision: > > Fix incompatible pointer types > > Signed-off-by: Justin King <jck...@google.com> Thanks for the ZGC update. I have a request to slightly modify the style a bit. Would you mind taking this patch: https://github.com/stefank/jdk/tree/pr_11931 There's a FIXME about that allocation.inline.hpp file is now empty. Will you remove it in this patch? I'd prefer if you did. Alternatively, remove the FIXME from this patch and then immediately clean this up as a separate patch. ------------- Changes requested by stefank (Reviewer). PR: https://git.openjdk.org/jdk/pull/11931
