On Wed, 8 Mar 2023 15:53:03 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> SA additional caching from Chris Plummer
>
> src/hotspot/share/classfile/classFileParser.cpp line 1634:
>
>> 1632: for(int i = 0; i < _temp_field_info->length(); i++) {
>> 1633: name = _temp_field_info->adr_at(i)->name(_cp);
>> 1634: sig = _temp_field_info->adr_at(i)->signature(_cp);
>
> This checking for duplicates looks like a good candidate for a separate
> function because parse_fields is so long. I'm adding this comment to
> remember to file an RFE to look into making this function shorter and factor
> out this code.
Filed a cleanup RFE https://bugs.openjdk.org/browse/JDK-8304069
-------------
PR: https://git.openjdk.org/jdk/pull/12855
