On Tue, 14 Mar 2023 22:48:30 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> The change: >> - updates UniqueVtableTest to follow standard SA way - attach to target from >> subprocess and use SATestUtils.addPrivilegesIfNeeded for the subprocess; >> - updates several tests in the same directory to resolve >> NoClassDefFoundError failures; It's known JTReg issue that "@build" actions >> for part of used shared classes may cause intermittent NoClassDefFoundError >> in other tests which use the same shared library classpath. >> >> Tested: 100 runs on all platforms, no failures > > test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 195: > >> 193: } else { >> 194: runTest(Long.parseLong(args[0])); >> 195: } > > Could use some comments here. Also, I think `SATestUtils.skipIfCannotAttach` > is only needed for the `else` part. "else" part is a sub-process. As far as I understand it SATestUtils.skipIfCannotAttach can be skipped for "else", but it's needed for main process. ------------- PR: https://git.openjdk.org/jdk/pull/13030