On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund <[email protected]> wrote:
> Greetings, > > For most platforms, os::dll_address_to_library_name() only sets offset = -1 > in case of errors. If there is an error, the function returns false. This is > fine. > > On AIX, the offset, being optional, is invariantly set to -1, even in the > case of non-errors. > > Easiest to remove the assertion for a positive offset. > > Thanks > Markus Removing the assertion seems the best course of action. It is interesting to note that the two call sites for these functions that pass `offset` do not correctly handle a return of -1 (it is only printed as an informational value but it isnb't printed in a suitable form). Thanks. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13513#pullrequestreview-1391171295
