On Fri, 28 Apr 2023 18:29:50 GMT, Frederic Parain <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove bool argument from ConstMethodFlags.set function.
>
> src/hotspot/share/oops/constMethod.cpp line 438:
>
>> 436: }
>> 437: st->cr();
>> 438: st->print(" - flags: "); _flags.print_on(st);
>> st->cr();
>
> Method prints its flags as an int and in decoded form, but ConstMethod only
> prints the decoded form. Any particular reason for this difference?
No reason for this difference. The only reason I added the int form for
MethodFlags was because AccessFlags were printed also with the int form.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13654#discussion_r1180712196
