On Tue, 2 May 2023 20:01:36 GMT, Chris Plummer <[email protected]> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002t.java >> line 78: >> >>> 76: /* >>> 77: * TEST #2: async exception while suspended at a breakpoint. >>> 78: */ >> >> Where is a similar comment for TEST #1 ? >> Would it make sense to implement each subtest as a separate method? > > Test #1 does not involve the debuggee since it is suppose to fail on the JDI > side with an exception. > > I don't think separate methods helps much here. It might even make it a bit > harder to understand the flow. > Test https://github.com/openjdk/jdk/pull/1 does not involve the debuggee > since it is suppose to fail on the JDI side with an exception. Still some comment is needed to explain this. Otherwise, it is confusing that the subtests start from the TEST #2. :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13548#discussion_r1183027318
