On Thu, 1 Jun 2023 22:51:23 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to >> allow deployment to choose whether to allow agents to be loaded/started in >> the VM. The VM option does the right thing for tools using the Attach API >> but jcmd JVMTI.agent_load was missed. This should be fixed to disallow >> loading JVMTI agents when the EnableDynamicAgentLoading is false. >> >> The CSR is: >> [JDK-8309250](https://bugs.openjdk.org/browse/JDK-8309250): jcmd >> JVMTI.agent_load should obey EnableDynamicAgentLoading >> >> Testing: >> - run new test `test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java` >> - TBD: submit mach5 tiers 1-5 to make sure no new regressions are introduced > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: use output.shouldContain() test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java line 57: > 55: OutputAnalyzer output = JcmdBase.jcmd(jcmdArgs); > 56: > 57: assertEquals(output.getExitValue(), 0); I think tests normally just use `output.shouldHaveExitValue(0);` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14244#discussion_r1213766546
