On Sat, 10 Jun 2023 02:56:47 GMT, Chris Plummer <[email protected]> wrote:
>> com/sun/jdi/SetLocalWhileThreadInNative.java is failing with >> OpaqueFrameException when using the virtual test thread factory. The reason >> is because JDI only supports calling StackFrame.setValue() on the topmost >> frame of a virtual thread. The test is calling it on the >> ThreadReference.frames(2), so the OpaqueFrameException is correct behavior >> and the test needs to adapt. >> >> I could have chosen to just not have this test support running on a virtual >> thread, but it appears to be the only test we have that attempts >> StackFrame.setValue() on something other than the topmost frame, so it's >> good to have it expect the OpaqueFrameException. >> >> Tested locally with and without the virtual thread wrapper. tier1 and tier5 >> svc testing tbd. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > caughtOPE -> caughtOFE Thanks for the reviews Leonid and Serguei! ------------- PR Comment: https://git.openjdk.org/jdk/pull/14402#issuecomment-1587826234
