On Wed, 21 Jun 2023 19:56:58 GMT, Chris Plummer <[email protected]> wrote:
>> Tom Rodriguez has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Flatten nested ifs
>> - Adjust ordering of message
>> - Adjust printing
>
> src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c line 309:
>
>> 307: print_debug("LC_SEGMENT_64 added: nsects=%d fileoff=0x%llx
>> vmaddr=0x%llx vmsize=0x%llx filesize=0x%llx %s\n",
>> 308: segcmd.nsects, segcmd.fileoff, segcmd.vmaddr,
>> segcmd.vmsize,
>> 309: segcmd.filesize, &segcmd.segname[0]);
>
> It would be nice to include this print_debug for the `filesize == 0` case.
> Maybe you can move it outside of the `if` and print `added` or `skipped`
> conditional on `filesize`.
Good idea. I've flattened the ifs a little and fixed the message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14569#discussion_r1240227363
