On Wed, 28 Jun 2023 13:16:30 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Hi Alan, regarding usage of class VM I get
>> 'package jdk.internal.misc is declared in module java.base, which does not
>> export it to module java.sql'
>> Is there any concern to export it as well to module java.sql ?
>> And btw did you mean to use it like this, in the if ?
>>
>> `
>> if (callerCL == null || VM.isSystemDomainLoader(callerCL)) {
>> callerCL = Thread.currentThread().getContextClassLoader();
>> }
>> `
>
>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is
>> declared in module java.base, which does not export it to module java.sql'
>> Is there any concern to export it as well to module java.sql ? And btw did
>> you mean to use it like this, in the if ?
>>
>> `if (callerCL == null || VM.isSystemDomainLoader(callerCL)) { callerCL =
>> Thread.currentThread().getContextClassLoader(); }`
>
> It was just a passing comment, I didn't meant to suggest changing it as part
> of this PR. We have always think twice before adding qualified exports from
> java.base and this is case where java.sql is very "non-core", we don't want
> to give it any access to java.base internals.
Hi Alan, thanks for clarifying. So I should only adjust the comment, correct ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1245204791
