On Thu, 29 Jun 2023 04:41:20 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
>> should return STATE_WAITING)
>> New test tests GetThreadState for different thread states.
>> The test detected a bug in the implementation, new issue is created:
>> JDK-8310584
>> Corresponding testcases are commented now in the test, fix for JDK-8310584
>> will uncomment them
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> spurious wakeups
test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedTest.java
line 62:
> 60: TestStatus status = new TestStatus("JVMTI_THREAD_STATE_RUNNABLE");
> 61: CountDownLatch ready = new CountDownLatch(1);
> 62: final boolean[] stopFlag = new boolean[1];
Q: It is not clear why an array is needed instead of non-final local. The same
question for `waiting()` method below.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14622#discussion_r1246698740
