On Wed, 27 Sep 2023 08:40:48 GMT, Varada M <d...@openjdk.org> wrote: >> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549) >> where AttachCurrentThread is failing on AIX due t stack size issue. >> Test cases: >> runtime/jni/terminatedThread/TestTerminatedThread.java >> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java >> >> vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/TestDescription.java >> >> vmTestbase/nsk/jvmti/SetJNIFunctionTable/setjniftab001/TestDescription.java >> >> Reported Issue : [JDK-8219652](https://bugs.openjdk.org/browse/JDK-8219652) > > Varada M has updated the pull request incrementally with one additional > commit since the last revision: > > Added pthread attritubes to libterminatedThread.c
That is much cleaner and simpler - thanks. A couple of minor nits, plus the ProblemList fixing that Chris mentioned. test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp line 132: > 130: #else // !windows & !sun > 131: pthread_attr_t attr; > 132: pthread_attr_init(&attr); You need a corresponding `pthread_attr_destroy` below. test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.cpp line 135: > 133: size_t stack_size = 0x100000; > 134: pthread_attr_setstacksize(&attr, stack_size); > 135: int result = pthread_create(&(thread->id),&attr,procedure,thread); As you are changing this line can you add spaces after the commas please. ------------- Changes requested by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15924#pullrequestreview-1647869605 PR Review Comment: https://git.openjdk.org/jdk/pull/15924#discussion_r1339511737 PR Review Comment: https://git.openjdk.org/jdk/pull/15924#discussion_r1339511485
