On Wed, 27 Sep 2023 21:34:37 GMT, Alex Menkov <[email protected]> wrote:
> The change fixes 2 issues in hprof test library.
> The issue were discovered during test development (logging values of dumped
> heap objects).
> - JavaValueArray.elementSize cannot determine size of the array elements and
> throws RuntimeException: invalid array element type
> - JavaObject.toString() method for dumped String objects tries to construct
> string value of the object from "value" field assuming "value" field is array
> of char. Actually it's byte array, so toString return array values like "{65,
> 66, 67}" (with fixed JavaValueArray.elementSize)
Just a minor nit. Otherwise looks good.
test/lib-test/jdk/test/lib/hprof/HprofTest.java line 43:
> 41:
> 42: /**
> 43: * @test
Add an `@bug`
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15953#pullrequestreview-1649733063
PR Review Comment: https://git.openjdk.org/jdk/pull/15953#discussion_r1340682712
