On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger <[email protected]>
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixed event location
test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 76:
> 74: while(eventIterator.hasNext() && start + TIMEOUT >
> System.currentTimeMillis()) {
> 75: Event event = eventIterator.next();
> 76: if (event instanceof ExceptionEvent ex) {
It's a bit unclear to me why this test is even seeing the ExceptionEvent since
I don't see any place where an ExceptionEventRequest has been setup.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1362711317
