On Wed, 18 Oct 2023 23:47:43 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested fixes
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 94:
>
>> 92: if
>> (!ex.exception().type().name().equals("Ex")) {
>> 93: throw new RuntimeException("Exception
>> has wrong type: " + ex.exception().type().name());
>> 94: }
>
> Not a review but just a suggestion to refactor a little bit:
> The lines 75-94 can be placed into a method
> `verifyExceptionEvent(ExceptionEvent ex)`,
> so the `main()` method is smaller and better observable.
> Not pressure though, it is up to you.
I was also thinking something similar.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364783475
