On Thu, 26 Oct 2023 07:51:56 GMT, Johannes Bechberger <jbechber...@openjdk.org> 
wrote:

>> Fix race condition in debugger port selection, introduced with 
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>> 
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add suggested fixes

test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 212:

> 210:      */
> 211:     private static JDWP.ListenAddress 
> parseLaunchEchoListenAddress(String debuggeeOutput) {
> 212:         Pattern listenRegexp = Pattern.compile("Listen Args: \\b(.+)\\b 
> \\b(.+)\\b");

"Listen Args:" should be a static final and also referenced above where the 
"echo" command is used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16358#discussion_r1373766455

Reply via email to