On Thu, 2 Nov 2023 11:35:29 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> Fix race condition in debugger port selection, introduced with >> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920). >> >> Tested on my Mac M1, but it doesn't contain platform-dependent code. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor as requested Marked as reviewed by amenkov (Reviewer). test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 132: > 130: onthrow.isEmpty() ? > 131: JDWP::parseListenAddress : > 132: Launcher::parseLaunchEchoListenAddress Please increase indent for conditional operator Suggestion: onthrow.isEmpty() ? JDWP::parseListenAddress : Launcher::parseLaunchEchoListenAddress or Suggestion: onthrow.isEmpty() ? JDWP::parseListenAddress : Launcher::parseLaunchEchoListenAddress ------------- PR Review: https://git.openjdk.org/jdk/pull/16358#pullrequestreview-1711398441 PR Review Comment: https://git.openjdk.org/jdk/pull/16358#discussion_r1380882396
