On Wed, 1 Nov 2023 17:10:34 GMT, Kevin Walls <[email protected]> wrote:
> Discovered while testing changes that made this test fail. The test failure
> is hard to diagnose as it logs and retries at full speed, possibly forever,
> until timeout. This can hit a log file limit. We can save thousands of
> lines of text being printed when the test runs normally and successfully, by
> waiting half a second before doing the Principal-checking which is the
> purpose of the test.
Looks reasonable.
Thanks,
Serguei
test/jdk/javax/management/monitor/ThreadPoolAccTest.java line 167:
> 165: String expected = principals[i / 3];
> 166:
> 167: echo("testPrincipals: monitored: " + monitored[i] + "
> principal: " + principal + " expected: " + expected);
With this in place, should printing of principal at line 176 be removed?
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16456#pullrequestreview-1710643924
PR Review Comment: https://git.openjdk.org/jdk/pull/16456#discussion_r1380362829
