On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko <rmarche...@openjdk.org> 
wrote:

>> Zero'ing memory of extension event callbacks
>
> Roman Marchenko has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fixing review comments

Sure. Here's the relevant sub-section from the "OpenJDK Developers’ Guide":

https://openjdk.org/guide/index.html#life-of-a-pr

Get the required reviews

At least one Reviewer knowledgeable in each area being changed must approve 
every change. Some areas (e.g. Client and HotSpot) require two reviewers in 
most cases, so be sure to read the relevant OpenJDK group pages for advice or 
ask your sponsor.

Be open to comments and polite in replies. Remember that the reviewer wants to 
improve the world just as much as you do, only in a slightly different way. If 
you don’t understand some comment, ask the reviewer to clarify. Accept 
authority when applicable. If you’re making changes in an area where you’re not 
the area expert, acknowledge that your reviewers may be. Take their advice 
seriously, even if it is to not make the change. There are many reasons [why a 
change may get 
rejected](https://openjdk.org/guide/index.html#why-is-my-change-rejected). And 
you did read the section [Things to consider before changing OpenJDK code], 
right?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16647#issuecomment-1813094911

Reply via email to