Re: RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object [v7]

[Stefan Karlsson]

On Mon, 27 Nov 2023 19:04:42 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

> The fix looks good to me. How was this tested?

Thanks. It was tested with the added and updated tests in GHA. Do you have any 
suggestions for more tests to run?

> test/hotspot/jtreg/runtime/Monitor/libMonitorWithDeadObjectTest.c line 168:
> 
>> 166:     if (pthread_create(&attacher, NULL, 
>> create_monitor_with_dead_object_and_dump_threads_in_thread, NULL) != 0) 
>> die("pthread_create");
>> 167:     if (pthread_join(attacher, &ret) != 0) die("pthread_join");
>> 168: }
> 
> The lines 153-167 have an inconsistent indent.

Fixed. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16783#issuecomment-1828467777
PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1406636914