On Fri, 1 Dec 2023 12:16:29 GMT, Alan Bateman <[email protected]> wrote:
>> This is a docs only change to j.l.management.ThreadInfo::isInNative.
>>
>> The method currently specifies that it tests if the thread is "executing
>> native code via the Java Native Interface (JNI)". It would be clearer to
>> say that it tests if the thread is executing a native method, and expand it
>> to include native code invoked using the new foreign linker APIs. For now,
>> I've left out the detail of a downcall handle created with the "critical"
>> linker option.
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains seven additional
> commits since the last revision:
>
> - Extend description
> - Merge
> - Change link to downcallHandle
> - Merge
> - Simplify wording
> - Merge
> - Initial commit
Thank you Alan for this latest update in commit `4836a9d` - it's much more
clear on what's considered native code.
src/java.management/share/classes/java/lang/management/ThreadInfo.java line 552:
> 550: *
> 551: * <p> A thread is considered to be executing native code when it is
> executing a
> 552: * native method, executing native code invoked using a {@linkplain
Nit - should "native method" be "{@code native} method"?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16791#issuecomment-1836064630
PR Review Comment: https://git.openjdk.org/jdk/pull/16791#discussion_r1412065761
