On Fri, 5 Jan 2024 00:47:48 GMT, Denghui Dong <dd...@openjdk.org> wrote:
>> Hi, >> >> Please help review this patch that fixes the failures of >> FullGCHeapDumpLimitTest.java caused by passing other gc flags. >> >> Thanks. > > Denghui Dong has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - update > - Merge remote-tracking branch 'origin/master' into JDK-8322989 > - update > - update > - 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java > fails Seems reasonable based on previous discussions. You may need to update the Alibaba copyright header now it is 2024 (depends on their rules, whatever they may be). Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17263#pullrequestreview-1805253887