On Wed, 10 Jan 2024 05:20:27 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright headers > > src/hotspot/share/prims/jvmtiEnv.cpp line 2910: > >> 2908: result_list[i] = jfieldIDWorkaround::to_jfieldID( >> 2909: ik, flds.offset(), >> 2910: flds.access_flags().is_static()); > > I think the indent here should be 4, not 6. You said in the description that the order was reversed, but I don't see where that is getting fixed. It seems it was partially fixed by [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692), but it is only preserving the class hierarchy order, but not the order of fields within each class. If that's all you are attempting to do, then please make it clear in the description. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17094#discussion_r1446898843
