On Fri, 12 Jan 2024 10:27:53 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix default filename issue
>
> src/hotspot/share/services/diagnosticCommand.cpp line 866:
>
>> 864: const char* filename = _filename.value();
>> 865: if (strncmp(filename, DEFAULT_PERFMAP_FILENAME,
>> strlen(DEFAULT_PERFMAP_FILENAME)) == 0) {
>> 866: filename = nullptr; // use the default filename based on the pid
>
> Nit: the indent has to be 2, not 4.
I only expected to see a change to the help string, I don't understand why the
actual Dcmd is being modified here! ???
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17359#discussion_r1451634237
