On Tue, 23 Jan 2024 19:57:14 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated option description and assertion based on review feedback > > I support keeping the logic under a flag. I have some concerns about > unconditionally turning it on. > > I expect significantly higher footprint overhead when an application has > plenty of tiny methods and deep inlining trees. And java.lang.invoke > implementation pushes it even further (with arbitrarily deep MethodHandle > trees and unconditional inlining through them), so heavy users of > MethodHandle API should experience higher overheads when evol dependencies > are recorded. > > I suggest to make the flag experimental. Once JFR implementation is improved, > it can be superseded by `-XX:+EnableDynamicAgentLoading` check. @iwanowww , @shipilev , @dean-long any more comments or concerns? Otherwise I'd like to finish this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17509#issuecomment-1910218698
