On Sat, 27 Jan 2024 13:09:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address >> https://bugs.openjdk.org/browse/JDK-8324668? >> >> This change proposes to fix the issue in jdwp where when launching a child >> process (for the `launch=<cmd>` option), it iterates over an extremely large >> number of file descriptors to close each one of those. Details about the >> issue and the proposed fixed are added in a subsequent comment in this PR >> https://github.com/openjdk/jdk/pull/17588#issuecomment-1912256075. tier1, >> tier2 and tier3 testing is currently in progress with this change. > > Jaikiran Pai has updated the pull request incrementally with two additional > commits since the last revision: > > - log a warning message if we fallback to slower logic of closing file > descriptors > - ignore return values, cast to void Thank you David for those inputs, I've updated the PR to implement those suggestions. CI tests continue to pass with these latest changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17588#issuecomment-1914348518
