On Thu, 1 Feb 2024 01:38:21 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix adds new test for FollowReferences JVMTI function to verify >> correctness of reported field indexes. > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > feedback Nice test, thank you for developing it! Looks good. test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp line 512: > 510: JNIEXPORT jboolean JNICALL > 511: Java_FieldIndicesTest_testFailed(JNIEnv *env, jclass cls) { > 512: return test_failed ? JNI_TRUE : JNI_FALSE; The indent for native files has to be 2, not 4. Even though there are still some tests with wrong indents I'd suggest for new files to follow this rule. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17580#pullrequestreview-1858460187 PR Review Comment: https://git.openjdk.org/jdk/pull/17580#discussion_r1475611992