On Wed, 14 Feb 2024 19:57:00 GMT, Chris Plummer <[email protected]> wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains one commit:
>>
>> sa-move-generation
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java
> line 112:
>
>> 110: public boolean isIn(Address p) {
>> 111: GenerationIsInClosure blk = new GenerationIsInClosure(p);
>> 112: spaceIterate(blk);
>
> It looks like spaceIterate() is no longer needed.
And I think you can get rid of GenerationIsInClosure also.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17844#discussion_r1490000450
