On Tue, 19 Mar 2024 10:13:16 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> So far we only use the gzip level setting from jcmd, not HeapDumpGzipLevel . >> See the `level` variable in `HeapDumpDCmd::execute` . Yeah you are probably >> right we should make it consistent. > >> If -XX:HeapDumpPath is specified, then it is used as the default > > No, the filename set with jcmd GC:heamp_dump filename has priority. So we > should better keep the current description. So should I also use HeapDumpGzipLevel the same way as HeapDumpPath ? Tehn we have to change the text in globals.hpp for HeapDumpGzipLevel as well because it mentions only the HeapDumpOnOutOfmemoryError case and not the jcmd case . ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18190#discussion_r1530082635
