On Thu, 21 Mar 2024 15:10:14 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: updated test with one more call to notifyAtBreakpoint to reset the
>> native state
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/PopFrameTest.java
> line 148:
>
>> 146: log("Main #B.2: got expected JVMTI_ERROR_NONE");
>> 147: resumeThread(testTaskThread);
>> 148: ensureAtBreakpoint();
>
> Not sure if it should work.
> Thevariable `bp_sync_reached` is reset in notifyAtBreakpoint().
> I see the previous call to ensureAtBreakpoint(); in line 131. So it means
> that
> bp_sync_reached is true in this line and never rest after it between 131 and
> 148.
> So I expect that this check in 148 is just return always without waiting
> anything. So it is not clear for me what is expected here.
Nice catch, thanks.
Added one more call to `notifyAtBreakpoint()` to reset the state variable
`bp_sync_reached`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1534373208
