On Tue, 2 Apr 2024 00:22:28 GMT, Serguei Spitsyn <[email protected]> wrote:
> The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure`
> classes were introduced in the JDK 22 to unify/simplify the JVM TI functions
> supporting implementation of the virtual threads. This enhancement is to
> refactor JVM TI functions `PopFrame` and `ForceEarlyReturn` on the base of
> `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes.
>
> Testing:
>
> Ran mach5 tiers 1-6
Changes requested by lmesnik (Reviewer).
src/hotspot/share/prims/jvmtiEnvBase.hpp line 503:
> 501: _value(value),
> 502: _tos(tos) {}
> 503: void doit(Thread *target, bool self);
No need to use self, you might use _self from doit().
src/hotspot/share/prims/jvmtiEnvBase.hpp line 508:
> 506: }
> 507: void do_vthread(Handle target_h) {
> 508: assert(_target_jt != nullptr, "sanity check");
Better to test that target_h is same as _target_jt.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18570#pullrequestreview-1987919902
PR Review Comment: https://git.openjdk.org/jdk/pull/18570#discussion_r1556693843
PR Review Comment: https://git.openjdk.org/jdk/pull/18570#discussion_r1556694346
