On Tue, 9 Apr 2024 00:56:16 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: cleanup - removed temporary logging used for debugging
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2070:
>
>> 2068: void
>> 2069: GetSingleStackTraceClosure::do_thread(Thread *target) {
>> 2070: doit();
>
> I think it makes sense to check that the target is the same as _target_jt. So
> we don't call it with arbitrary threads.
> or require parameter to be null if you want.
> Same for do_vthread.
Thank you for suggestion. Added asserts.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18574#discussion_r1558748415
