On Fri, 12 Apr 2024 21:08:54 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The test starts listening on dynamic port and calls stopListening with >> incorrect (cArgs1) and correct (cArgs2) argument maps. >> Incorrect map is created by finding "free" port (`(new >> ServerSocket(0)).getLocalPort()`) >> The test fails if the same port is selected later when the listening starts. >> To avoid this free port should be picked after listening on dynamic port >> started. >> >> Additionally removed unnecessary `exclusiveAccess.dirs=.` test property and >> incorrect comment in the description. >> The test uses `SocketListen` connectors, the coment is about >> `SharedMemoryListen` connector. >> >> Testing: run the test on all Oracle-supported platforms 100 times > > Alex Menkov has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge branch 'stopListening' of github.com:alexmenkov/jdk into > stopListening > - arg map logging Marked as reviewed by cjplummer (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/18705#pullrequestreview-1998507304
