On Mon, 15 Apr 2024 21:34:48 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: removed event_lock; moved wait_for_state() to jvmti_common.hpp > > test/hotspot/jtreg/serviceability/jvmti/ObjectMonitorUsage/libObjectMonitorUsage.cpp > line 183: > >> 181: >> 182: static void wait_for_state(JNIEnv *jni, jthread thread, jint exp_state) >> { >> 183: RawMonitorLocker rml(jvmti, jni, event_lock); > > The event_lock name is misleading, there are no events anymore. > Also, I am not sure if this lock is needed at all. How it is used? > > I think that wait_for_state is a good candidate to be added in the library. > With some additional doc about states. Good suggestions, thanks. Implemented now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18778#discussion_r1566755184