On Mon, 13 May 2024 13:52:17 GMT, Dmitry Chuyko <dchu...@openjdk.org> wrote:
> Are there any high severity problems caused by the original PR? Especially > not in the new functionality. Minor issues could be probably addressed > without backing out the entire functionality. Yes, there are: > 1. Usually directives are updated for a small number of Java methods. If > CodeCache has thousands of nmethods, > CodeCache::recompile_marked_directives_matches will be traversing nmethods > most of which don't need recompilation. > 2. has_matching_directives might not be cleared. > 3. A Java method is not recompiled as requested. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19215#issuecomment-2107720199
