On Fri, 17 May 2024 07:44:29 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> It's probably easier to read the new code directly. The two classes in >> `serialVMOperations` serve as entrance points to invoke young/full GCs. Some >> previously hidden decisions are made more obvious, e.g. if a young-gc fails >> (or will probablly fail), fallback to full-gc. >> >> Additionally, `StatRecord` is removed, because this kind of info-aggregation >> should be done outsite VM (by third-party tool). >> >> Test: tier1-6 > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains ten commits: > > - review > - Merge branch 'master' into s1-do-collect > - Merge branch 'master' into s1-do-collect > - review > - Merge branch 'master' into s1-do-collect > - merge > - review > - Merge branch 'master' into s1-do-collect > - s1-do-collect Looks good! Thanks for the cleanup. ------------- Marked as reviewed by iwalulya (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19056#pullrequestreview-2062603522