On Tue, 28 May 2024 20:55:30 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The vmTestbase/nsk/share/LocalProcess.java is a wrapper for debuggee >> process. It extends FinalizableObject to kill the debuggee process. >> >> The debuggee process is used by nsk.jdb tests only, see runTest(...) in >> vmTestbase/nsk/share/jdb/JdbTest.java: >> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/vmTestbase/nsk/share/jdb/JdbTest.java#L189 >> >> I verified that process is always already terminated when is cleaned during >> VM shutdown hook, >> So the fix is just to remove the finalization. >> >> I also moved LocalProcess into nsk.share.jdb to reduce the visibility of >> class and hardened checks in runTest. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fixed check Marked as reviewed by amenkov (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19418#pullrequestreview-2084083384
