On Fri, 31 May 2024 17:33:47 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix Boot-Class-Path value for Windows
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.java line 168:
>
>> 166:
>> 167: private static void launchApp(final Path agentJar) throws Exception
>> {
>> 168: final OutputAnalyzer oa = ProcessTools.executeLimitedTestJava(
>
> Is there any reason the test uses 'executeLimitedTestJava' and not
> 'executeTestJava'?
> It might make sense to run it with different VM flags.
Hello Leonid, I had intentionally used `executeLimitedTestJava()` to avoid
passing along any additional options when launching that test application jar
because it wasn't clear to me if passing those along will be of any use.
Especially, options like `-Xcomp` which might be used when launching jtreg.
That was the sole reason.
Having said that, I have now updated the tests to use `executeTestJava()` to
allow them to pass along these options to the jar being launched, since prior
to this change, the test would have anyway ended up using those additional
jtreg launch specific options.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1623170660
