On Tue, 4 Jun 2024 08:50:53 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>> - Stop virtualthread
>> - Remove unneeded imports
>> - Remove modules that are not needed
>> - Fix copyright year
>
> src/hotspot/share/runtime/threads.cpp line 1334:
>
>> 1332: if (thread_oop != nullptr) {
>> 1333: if (p->is_vthread_mounted()) {
>> 1334: oop vt = p->vthread();
>
> const
Thanks ! I've fixed that in: a483113a7ff381860dec3d52a45e18d8a0fdc929
> src/hotspot/share/runtime/threads.cpp line 1335:
>
>> 1333: if (p->is_vthread_mounted()) {
>> 1334: oop vt = p->vthread();
>> 1335: assert(vt != nullptr, "");
>
> Please provide a valid assert string.
Thanks ! I've fixed that in: a483113a7ff381860dec3d52a45e18d8a0fdc929
> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java
> line 52:
>
>> 50: output.shouldMatch(".*at " +
>> Pattern.quote(DummyRunnable.class.getName()) + "\\.run.*");
>> 51: output.shouldMatch(".*at " +
>> Pattern.quote(DummyRunnable.class.getName()) + "\\.compute.*");
>> 52: shouldFinish.compareAndSet(false, true);
>
> Why not just set?
Thanks ! I've fixed that in: a483113a7ff381860dec3d52a45e18d8a0fdc929
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1626012756
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1626012662
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1626012524
