On Tue, 18 Jun 2024 09:29:34 GMT, David Holmes <[email protected]> wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve assert and document conditional print
>
> src/hotspot/share/runtime/threads.cpp line 1336:
>
>> 1334: assert(vt != nullptr, "vthread should not be null when
>> vthread is mounted");
>> 1335: if (vt != thread_oop) {
>> 1336: // JavaThread._vthread can refer to the carrier thread.
>> Print only if _vthread refers to a virtual thread.
>
> Nit: please put the comment before the `if`
Thanks ! I've fixed that in: 05c0f75acd6a37815146c7a7e1b30aede47ab77a
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19744#discussion_r1644321149
